feat(themes): add rulers for themes missing them #10309
Conversation
This now matches `solarized_dark` changes from helix-editor#10261
Also changed the colors to better blend with the theme.
This change also propagates to `poimandres-storm`
|
I don't use these themes myself, so unsure how an 8 hour coding session will affect contrast perception for some of these. But at least now there is a config option they can check and modify if its not working. |
pascalkuthe
added
A-theme
|
Also, what seemed to be holding up #3599 was the breaking of |
Yeah if we merge this that could be ok. But I wanted a better solution where rulers get rendered after the base highlights but before overlays like selections. We made some changes to the rendering system since and it's now possible to render in between those two so that would be a better solution. |
|
\cc @archseer as this affects the default theme |
As talked about here, I went through and searched for any
ui.virtual.rulerusingfg.rg -iN '\"ui.virtual.ruler\"?\s=?\s\{?\sfg?\s=?\s\"\w+"?\s\}' runtime/themes/After these changes the above grep yields no results.
Along the way, I addressed other issues brought up in #5721, and added rulers to themes that didn't have one. For those where the ruler was invisible, there is now one that shows up, and for those where the ruler was bright red, it should now match the theme better.
default:solarized_dark:solarized_light:horizon-dark:mellow:poimandres:poimandres-storm:varua:vim_dark_high_contrast:base16_default:base16_default_dark:base16_default_light:base16_default_terminal:I also took the liberty and normalized the change in #10261 for
solzarized_lightCloses: #5721